Allow nunlable to booleans needed due NC 22 changes.

This commit is contained in:
Matias De lellis
2021-07-08 11:58:24 -03:00
parent fe94cfc5cf
commit 551f1d8ce4
6 changed files with 51 additions and 79 deletions

View File

@@ -127,35 +127,6 @@ class Version000204Date20200530211356 extends SimpleMigrationStep {
$table->setPrimaryKey(['id']);
}
if (!$schema->hasTable('quicknotes_tasks')) {
$table = $schema->createTable('quicknotes_tasks');
$table->addColumn('id', 'bigint', [
'autoincrement' => true,
'notnull' => true,
'length' => 8,
'unsigned' => true,
]);
$table->addColumn('note_id', 'bigint', [
'notnull' => true,
'length' => 8,
'unsigned' => true,
]);
$table->addColumn('description', 'string', [
'notnull' => true,
'length' => 200,
'default' => '',
]);
$table->addColumn('done', 'boolean', [
'notnull' => true,
'default' => false,
]);
$table->addColumn('ordering', 'integer', [
'notnull' => true,
'default' => 0,
]);
$table->setPrimaryKey(['id']);
}
if (!$schema->hasTable('quicknotes_shares')) {
$table = $schema->createTable('quicknotes_shares');
$table->addColumn('id', 'bigint', [

View File

@@ -26,7 +26,7 @@ class Version000205Date20200604122312 extends SimpleMigrationStep {
$table = $schema->getTable('quicknotes_notes');
$table->addColumn('pinned', 'boolean', [
'notnull' => true,
'notnull' => false,
'default' => false,
]);
return $schema;

View File

@@ -0,0 +1,48 @@
<?php
declare(strict_types=1);
namespace OCA\QuickNotes\Migration;
use Closure;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;
/**
* Auto-generated migration step: Please modify to your needs!
*/
class Version00720Date20210708130231 extends SimpleMigrationStep {
/**
* @param IOutput $output
* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
* @param array $options
* @return null|ISchemaWrapper
*/
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
/** @var ISchemaWrapper $schema */
$schema = $schemaClosure();
if ($schema->hasTable('quicknotes_tasks')) {
$schema->dropTable('quicknotes_tasks');
}
$this->ensureColumnIsNullable($schema, 'quicknotes_notes', 'pinned');
return $schema;
}
protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
$table = $schema->getTable($tableName);
$column = $table->getColumn($columnName);
if ($column->getNotnull()) {
$column->setNotnull(false);
return true;
}
return false;
}
}