Fix response when dont have notes. Issue #44

This commit is contained in:
Matias De lellis
2020-10-03 17:34:31 -03:00
parent c25964544c
commit b4711815ef
2 changed files with 8 additions and 4 deletions

View File

@@ -54,14 +54,16 @@ class NoteApiController extends ApiController {
*/
public function index(): JSONResponse {
$notes = $this->noteService->getAll($this->userId);
$etag = md5(json_encode($notes));
if (count($notes) === 0) {
return new JSONResponse([]);
}
$lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$timestamp = max(array_map(function($note) { return $note->getTimestamp(); }, $notes));
$lastModified->setTimestamp($timestamp);
$response = new JSONResponse($notes);
$response->setETag($etag);
$response->setETag(md5(json_encode($notes)));
$response->setLastModified($lastModified);
return $response;