Minz/quicknotes
1
0
Fork 0
mirror of https://github.com/JanGross/quicknotes.git synced 2025-11-30 23:37:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix response when dont have notes. Issue #44

Browse Source
This commit is contained in:
Matias De lellis
2020-10-03 17:34:31 -03:00
parent c25964544c
commit b4711815ef
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Controller/NoteApiController.php
View File

@@ -54,14 +54,16 @@ class NoteApiController extends ApiController {
*/ */
public function index(): JSONResponse { public function index(): JSONResponse {
$notes = $this->noteService->getAll($this->userId); $notes = $this->noteService->getAll($this->userId);
$etag = md5(json_encode($notes)); if (count($notes) === 0) {
return new JSONResponse([]);
}
$lastModified = new \DateTime(null, new \DateTimeZone('GMT')); $lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$timestamp = max(array_map(function($note) { return $note->getTimestamp(); }, $notes)); $timestamp = max(array_map(function($note) { return $note->getTimestamp(); }, $notes));
$lastModified->setTimestamp($timestamp); $lastModified->setTimestamp($timestamp);
$response = new JSONResponse($notes); $response = new JSONResponse($notes);
$response->setETag($etag); $response->setETag(md5(json_encode($notes)));
$response->setLastModified($lastModified); $response->setLastModified($lastModified);
return $response; return $response;

6
lib/Controller/NoteController.php
View File

@@ -52,14 +52,16 @@ class NoteController extends Controller {
*/ */
public function index(): JSONResponse { public function index(): JSONResponse {
$notes = $this->noteService->getAll($this->userId); $notes = $this->noteService->getAll($this->userId);
$etag = md5(json_encode($notes)); if (count($notes) === 0) {
return new JSONResponse([]);
}
$lastModified = new \DateTime(null, new \DateTimeZone('GMT')); $lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$timestamp = max(array_map(function($note) { return $note->getTimestamp(); }, $notes)); $timestamp = max(array_map(function($note) { return $note->getTimestamp(); }, $notes));
$lastModified->setTimestamp($timestamp); $lastModified->setTimestamp($timestamp);
$response = new JSONResponse($notes); $response = new JSONResponse($notes);
$response->setETag($etag); $response->setETag(md5(json_encode($notes)));
$response->setLastModified($lastModified); $response->setLastModified($lastModified);
return $response; return $response;