From d1d1f1a2f6fa7ee03f5d95c3e62ba6d52e28a560 Mon Sep 17 00:00:00 2001
From: Matias De lellis <mati86dl@gmail.com>
Date: Fri, 14 Dec 2018 10:45:39 -0300
Subject: [PATCH] Do happy to NC app:check.. =)

---
 appinfo/info.xml              | 9 +++++----
 controller/notecontroller.php | 4 ++--
 service/noteservice.php       | 2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/appinfo/info.xml b/appinfo/info.xml
index 656b543..44365d6 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -1,11 +1,13 @@
 <?xml version="1.0"?>
-<info>
+<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
+      xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
     <id>quicknotes</id>
     <name>Quick notes</name>
+    <summary>Quick notes with a basic rich text</summary>
     <description>Quick notes with a basic rich text</description>
-    <licence>AGPL</licence>
-    <author>Matias De lellis</author>
     <version>0.1.5</version>
+    <licence>agpl</licence>
+    <author>Matias De lellis</author>
     <namespace>QuickNotes</namespace>
     <category>office</category>
     <category>tools</category>
@@ -14,7 +16,6 @@
     <repository type="git">https://github.com/matiasdelellis/quicknotes.git</repository>
     <screenshot small-thumbnail="https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png">https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png</screenshot>
     <screenshot>https://user-images.githubusercontent.com/733715/38871255-b07a7d5a-4226-11e8-8403-650cbea50be0.png</screenshot>
-    <ocsid>174716</ocsid>
     <dependencies>
         <nextcloud min-version="14" max-version="14" />
     </dependencies>
diff --git a/controller/notecontroller.php b/controller/notecontroller.php
index 6658a76..460faac 100644
--- a/controller/notecontroller.php
+++ b/controller/notecontroller.php
@@ -160,7 +160,7 @@ class NoteController extends Controller {
 		$newnote = $this->notemapper->update($note);
 
 		//  Remove old color if necessary
-		if (($oldcolorid != $hcolor->getId()) &&
+		if (($oldcolorid !== $hcolor->getId()) &&
 		    (!$this->notemapper->colorIdCount($oldcolorid))) {
 			$oldcolor = $this->colormapper->find($oldcolorid);
 			$this->colormapper->delete($oldcolor);
@@ -234,7 +234,7 @@ class NoteController extends Controller {
 		$shares = $this->notesharemapper->getSharesForNote($noteId);
 		foreach($shares as $s) {
 			$shareType = $s->getSharedUser();
-			if(strlen($shareType) != 0) {
+			if(strlen($shareType) !== 0) {
 				if(($i = array_search($shareType, $users)) !== false) {
 					unset($users[$i]);
 					$pos_users[] = $shareType;
diff --git a/service/noteservice.php b/service/noteservice.php
index 44a64c6..34e3ac2 100644
--- a/service/noteservice.php
+++ b/service/noteservice.php
@@ -58,7 +58,7 @@ class NoteService {
 			$note = $this->mapper->find($id, $userId);
 			$note->setTitle($title);
 			$note->setContent($content);
-			$note->setColor($color)
+			$note->setColor($color);
 			return $this->mapper->update($note);
 		} catch(Exception $e) {
 			$this->handleException($e);