From aea807ca3cf1d5826d38217465ea3589fe266b79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Gro=C3=9F?= <git@minzkraut.com>
Date: Mon, 17 Apr 2023 16:00:12 +0200
Subject: [PATCH] API: Properly handle not found cases for groups and
 characters

---
 api/routes/characters.js | 2 +-
 api/routes/groups.js     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/api/routes/characters.js b/api/routes/characters.js
index 7ddc37d..4c13c08 100644
--- a/api/routes/characters.js
+++ b/api/routes/characters.js
@@ -28,7 +28,7 @@ router.get('/characters', async (req, res) => {
 router.get('/characters/:character_id', async (req, res) => {
     let character = await Character.findByPk(req.params.character_id);
 
-    if (!character.enabled && !isAuthorized(req)) {
+    if (!character || !character.enabled && !isAuthorized(req)) {
         res.status(404).json({ error: 'Character not found' });
         return;
     }
diff --git a/api/routes/groups.js b/api/routes/groups.js
index de55e5a..bddf82c 100644
--- a/api/routes/groups.js
+++ b/api/routes/groups.js
@@ -28,7 +28,7 @@ router.get('/groups', async (req, res) => {
 router.get('/groups/:group_id', async (req, res) => {
     let group = await Group.findByPk(req.params.group_id);
 
-    if (!group.enabled && !isAuthorized(req)) {
+    if (!group || !group.enabled && !isAuthorized(req)) {
         res.status(404).json({ error: 'Group not found' });
         return;
     }