Do happy to NC app:check.. =)

This commit is contained in:
Matias De lellis
2018-12-14 10:45:39 -03:00
parent b899ca2381
commit d1d1f1a2f6
3 changed files with 8 additions and 7 deletions

View File

@@ -1,11 +1,13 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<info> <info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>quicknotes</id> <id>quicknotes</id>
<name>Quick notes</name> <name>Quick notes</name>
<summary>Quick notes with a basic rich text</summary>
<description>Quick notes with a basic rich text</description> <description>Quick notes with a basic rich text</description>
<licence>AGPL</licence>
<author>Matias De lellis</author>
<version>0.1.5</version> <version>0.1.5</version>
<licence>agpl</licence>
<author>Matias De lellis</author>
<namespace>QuickNotes</namespace> <namespace>QuickNotes</namespace>
<category>office</category> <category>office</category>
<category>tools</category> <category>tools</category>
@@ -14,7 +16,6 @@
<repository type="git">https://github.com/matiasdelellis/quicknotes.git</repository> <repository type="git">https://github.com/matiasdelellis/quicknotes.git</repository>
<screenshot small-thumbnail="https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png">https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png</screenshot> <screenshot small-thumbnail="https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png">https://user-images.githubusercontent.com/733715/38871311-dac5a80a-4226-11e8-961d-63b276380b6b.png</screenshot>
<screenshot>https://user-images.githubusercontent.com/733715/38871255-b07a7d5a-4226-11e8-8403-650cbea50be0.png</screenshot> <screenshot>https://user-images.githubusercontent.com/733715/38871255-b07a7d5a-4226-11e8-8403-650cbea50be0.png</screenshot>
<ocsid>174716</ocsid>
<dependencies> <dependencies>
<nextcloud min-version="14" max-version="14" /> <nextcloud min-version="14" max-version="14" />
</dependencies> </dependencies>

View File

@@ -160,7 +160,7 @@ class NoteController extends Controller {
$newnote = $this->notemapper->update($note); $newnote = $this->notemapper->update($note);
// Remove old color if necessary // Remove old color if necessary
if (($oldcolorid != $hcolor->getId()) && if (($oldcolorid !== $hcolor->getId()) &&
(!$this->notemapper->colorIdCount($oldcolorid))) { (!$this->notemapper->colorIdCount($oldcolorid))) {
$oldcolor = $this->colormapper->find($oldcolorid); $oldcolor = $this->colormapper->find($oldcolorid);
$this->colormapper->delete($oldcolor); $this->colormapper->delete($oldcolor);
@@ -234,7 +234,7 @@ class NoteController extends Controller {
$shares = $this->notesharemapper->getSharesForNote($noteId); $shares = $this->notesharemapper->getSharesForNote($noteId);
foreach($shares as $s) { foreach($shares as $s) {
$shareType = $s->getSharedUser(); $shareType = $s->getSharedUser();
if(strlen($shareType) != 0) { if(strlen($shareType) !== 0) {
if(($i = array_search($shareType, $users)) !== false) { if(($i = array_search($shareType, $users)) !== false) {
unset($users[$i]); unset($users[$i]);
$pos_users[] = $shareType; $pos_users[] = $shareType;

View File

@@ -58,7 +58,7 @@ class NoteService {
$note = $this->mapper->find($id, $userId); $note = $this->mapper->find($id, $userId);
$note->setTitle($title); $note->setTitle($title);
$note->setContent($content); $note->setContent($content);
$note->setColor($color) $note->setColor($color);
return $this->mapper->update($note); return $this->mapper->update($note);
} catch(Exception $e) { } catch(Exception $e) {
$this->handleException($e); $this->handleException($e);